<div dir="ltr">Hi Chris,<div><br></div><div>Thanks for the patch. Just a minor point though: the default behaviour in MRtrix is to prevent any overwrite of existing image files (to prevent accidental loss of data). While there are undeniably pro & cons to this policy, for the sake of consistency it would be better if this just threw an exception if the file exists. I'll include such a patch upstream based on yours when I have a minute...</div>
<div><br></div><div>Cheers!</div><div>Donald.</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 2 May 2014 06:44, Chris Adamson <span dir="ltr"><<a href="mailto:chris.adamson@mcri.edu.au" target="_blank">chris.adamson@mcri.edu.au</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal">I found a serious bug when mrview overwrites an ROI image that is in nii gz format it crashes. This is a patch:<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">diff -ru b/lib/image/mapper.cpp a/lib/image/mapper.cpp<u></u><u></u></p>
<p class="MsoNormal">--- b/lib/image/mapper.cpp 2014-02-25 20:49:26.000000000 +1100<u></u><u></u></p>
<p class="MsoNormal">+++ a/lib/image/mapper.cpp 2014-05-02 15:37:46.547683468 +1000<u></u><u></u></p>
<p class="MsoNormal">@@ -210,6 +210,13 @@<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"> info ("writing compressed data to \"" + gzfile + "\"...");<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal">+ // check if file exists, <u></u><u></u></p>
<p class="MsoNormal">+ if(g_file_test (gzfile.c_str(), G_FILE_TEST_EXISTS)) {<u></u><u></u></p>
<p class="MsoNormal">+ if(g_unlink(gzfile.c_str()) == -1) {<u></u><u></u></p>
<p class="MsoNormal">+ fclose (infile);<u></u><u></u></p>
<p class="MsoNormal">+ throw Exception ("error deleting file \"" + gzfile + "\": " + Glib::strerror(errno));<u></u><u></u></p>
<p class="MsoNormal">+ }<u></u><u></u></p>
<p class="MsoNormal">+ }<u></u><u></u></p>
<p class="MsoNormal"> int fid = g_open (gzfile.c_str(), O_CREAT | O_RDWR | O_EXCL, 0755);<u></u><u></u></p>
<p class="MsoNormal"> if (fid < 0) {<u></u><u></u></p>
<p class="MsoNormal"> fclose (infile);<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal" style="margin-bottom:9.0pt"><b><span style="font-size:8.5pt;font-family:"Helvetica","sans-serif";color:#00a3d7">Dr </span></b><b><span style="font-size:8.5pt;font-family:"Arial","sans-serif";color:#00a3d7">Chris Adamson <br>
</span></b><span style="font-size:8.5pt;font-family:"Helvetica","sans-serif";color:#2c1376">Research Officer, Developmental Imaging, <b>Murdoch Childrens Research Institute <br>
</b></span><span style="font-size:8.5pt;font-family:"Arial","sans-serif";color:#929292">Murdoch Childrens Research Institute <br>
Royal Children’s Hospital<br>
Flemington Road, Parkville, Victoria 3052, Australia<br>
<a href="http://www.mcri.edu.au/" target="_blank"><span style="color:blue">www.mcri.edu.au</span></a></span><span style="font-size:8.5pt;font-family:"Arial","sans-serif";color:#2c1376"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:8.5pt;font-family:"Helvetica","sans-serif";color:#929292">E <a href="mailto:chris.adamson@mcri.edu.au" target="_blank">chris.adamson@mcri.edu.au</a>
<br>
T 03 9936 6780</span><span style="font-size:8.5pt;font-family:"Arial","sans-serif";color:#929292"> </span><u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<br clear="both">
______________________________________________________________________<br>
This email has been scanned by the Symantec Email Security.cloud service.<br>
For more information please visit <a href="http://www.symanteccloud.com" target="_blank">http://www.symanteccloud.com</a><br>
______________________________________________________________________<br>
</div>
<br>_______________________________________________<br>
Mrtrix-discussion mailing list<br>
<a href="mailto:Mrtrix-discussion@www.nitrc.org">Mrtrix-discussion@www.nitrc.org</a><br>
<a href="http://www.nitrc.org/mailman/listinfo/mrtrix-discussion" target="_blank">http://www.nitrc.org/mailman/listinfo/mrtrix-discussion</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><b><font color="#990000">Dr J-Donald Tournier (PhD)</font></b><br><div><font color="#990000"><br></font></div><i><font color="#990000">Senior Lecturer, </font></i><i><font color="#990000">Biomedical Engineering</font></i><div>
<i><font color="#990000">Division of Imaging Sciences & Biomedical Engineering<br>King's College London</font></i><div><i><font color="#990000"><br></font></i></div><div><i><font color="#990000"><b style="font-family:Calibri,sans-serif;font-size:15px"><span style="font-size:10pt">A:</span></b><span style="font-family:Calibri,sans-serif;font-size:10pt"> Department of Perinatal Imaging & Health, 1<sup>st</sup> Floor South Wing, St Thomas' Hospital, London. SE1 7EH</span><br>
</font></i></div><div><i><font color="#990000"><b>T:</b> +44 (0)20 7188 7118 ext 53613</font></i></div></div><div><i><font color="#990000"><b>W:</b> <a href="http://www.kcl.ac.uk/medicine/research/divisions/imaging/departments/biomedengineering" target="_blank">http://www.kcl.ac.uk/medicine/research/divisions/imaging/departments/biomedengineering</a></font></i><br>
</div></div>
</div>